Skip to main content

Make your objects immutable by default

More about the Good Dojo

In my post last week, I discussed creating objects that are instantiated safely. Please go back and read if you are interested.

At the end of the post, I mentioned that I'd also written the class so it was immutable when instantiated. This is important!!! I feel like a broken record in repeating this but I am sure at the time of writing your code, you aren't modifying your object all over the place and so are safe in the belief that protecting against mutability is overkill. Please remember though, your code could be around for a hell of a long time. You aren't writing your code for now...

you are writing for the next fool that comes along (including you)
.

Nothing is more upsetting that coming back to fix a bug on some wonderfully crafted code to say "Who has butchered my code?!", but often you were involved at the start of the process. You made the code easy to modify, allowing objects to be used / reused / modified without thinking of the implications.

The Good Dojo doesn't allow modifications once created.

We allow a Dojo to be created with or without students in the first place but once created, the only public way to access the Students is through an Enumerable which can't be modified. If we want to add a Student we control how the Student is added to the Dojo.

As systems become horrible and a multitude of different devs eventually begin to move your code about and add modifications, your object could end up making it's way all around a code base. Too many times in large systems have I pulled my hair out going down rabbit holes only to find someone had modified an object further down the line where I hadn't expected it or someone had wrapped an if() around some code that was assigning a value to my object (therefore leaving it null).

Again this is all obvious stuff (don't let people change your code without thinking about it). Check your code base, I bet you still have some rofl objects that started life out as "pocos" with { get; set; } on them...

Comments

Popular posts from this blog

Motorola MC65

We have a new PDA in town now. As a replacement for the army of MC9000 and MC70s that are in the field and are being discontinued, we now are moving up to the Motorola MC65. I have had the new handheld for about a week now and have been impressed so far. It's a great improvement over the MC70. I have no idea how the numbering system of the Symbol / Motorola devices works. I assume there must be several ranges such as the 50s 60s and 70s.? Anyway the?PDA?has windows mobile 6.5.3, a better touch screen and is faster. Much faster. The skin that has been put on the OS has also applied to our software and I think it makes it look much cooler. We had several problems in adjusting our software so it would work with the new MC65. First was the change in resolution. The MC70 has a much lower resolution than the MC65s and as some of our screens were not using the auto scale settings in the form and some of the buttons on our forms were created at run time rather than design time, this posed

Accessing the UI Thread with Tasks in F#

I have a Windows Forms program written in F# that can deploy a code base to n number of sites at once (you select the sites you would like to deploy to and it goes off and completes a number of tasks (backing up current sites, various unpacking and moving of files etc... ). Once you start it, it begins it's merry journey and begins to update the UI with what has happened. At the moment this method of updating the UI is not pretty because the threads I am doing the work on can't update the UI so I perform some fiendery to make that happen (don't ask). I knew there was a better way using some newer .NET features but I just hadn't got round to having a fiddle yet. I have now found that if you use the built in Task class but break your code up in a nicer way and then chain the tasks together you can then pass the correct context into the task that you want to talk to the UI. Here's a little script to give you a feel for it. You can press the "start" butt

Cab Control

Received another call today from a company interested in my  Cab Control Software . Basically it's taxi management . The software needs a re-write to get it from Windows Forms onto the web. I have great hopes for the software. It really just needs to time and ingenuity pouring into it. I have loads of ideas for it but just have so little time.  It currently has this functionality which I'll need to get across:  Add drivers and Taxis and keep track of their contact details, addresses, licence details, CRB checks and eligibility to work in the UK. Basic account management functions, such as creating a customer account and putting the account on hold.  Add Bookings for drivers and customers Creating reports for customer accounts that could be exported as a CSV file for billing purposes.  Creating reports for drivers to know how many pickups the drivers had made. Query the bookings for enquiries and police check up reports. Provide management tools to check MOT and Service details