Skip to main content

Dealing with DataTables

The nice thing about having someone join in a junior position at work is that it gives you a lot to blog (or repeat yourself) about. We've discussed a lot of subjects this week. One; was them being burned by some terrible old code that involved DataTables. There were a series of enormous (and broken) methods that accessed DataRows directly using the integer column index. There was a large amount of calculations directly on these items but the reason behind any of it was meaningless. The underlying Stored Procedure had changed causing an invalid cast exception.

In light of this, I thought it might be nice to go through a bit of a process of some different options of still using ado.net and why you might choose the options what the pitfalls were. Staying on topic, we didn't opt to use an SqlDataReader which would probably be the next option to go for considering how much faster that it. We talked about speed over maintainability, but I think even when we were programming on the compact framework on some fairly basic devices we still used string column references just for sanity. Some people use Enums to access the columns so that you can still stick with the ints but it maintains some meaning, my answer to that though is bog off. It still causes problems if someone changes the bloody schema underneath and if you need to squeeze the performance there, you have bigger problems.

Anyway! These is the code we discussed. In VB.NET mainly because, er why not. The original discussion was in C# but I just fancied doing it in VB.NET too.

Comments

Popular posts from this blog

Making your domain less mutable

This happens regularly to me (and from my anecdotal investigation everyone involved in large / old projects). We need a new piece of functionality. I write it, it's beautiful and I win the internet. I have estimated 8 days (or 22.23 lol-points depending on how you live) and it's only taken 4 days. Ah, but then a very small; mostly ignored and very unimportant detail rears it's cruel head. You need to make it work with the code that exists already. This is normally in the form of saving to some pre-existing entities. Oh dear. You save everything through the various management / service classes that exist already and nothing works. So begins the next couple of days of horror. You find that you didn't set the work = true . Most of my woes in this area are caused by modifications at layer further down (or the stored procedure it finally ends up in) changing the object that I was trying to save or not saving part of the object because of some rule. So many errors

Make your objects immutable by default

More about the Good Dojo In my post last week , I discussed creating objects that are instantiated safely. Please go back and read if you are interested. At the end of the post, I mentioned that I'd also written the class so it was immutable when instantiated. This is important!!! I feel like a broken record in repeating this but I am sure at the time of writing your code, you aren't modifying your object all over the place and so are safe in the belief that protecting against mutability is overkill. Please remember though, your code could be around for a hell of a long time. You aren't writing your code for now... you are writing for the next fool that comes along (including you) . Nothing is more upsetting that coming back to fix a bug on some wonderfully crafted code to say "Who has butchered my code?!", but often you were involved at the start of the process. You made the code easy to modify, allowing objects to be used / reused / modified without thi

IIS Administration using Microsoft.Web.Administration using F#

A friend had mentioned his joy at using Powershell. I guess this is pretty cool and I don't mind Powershell. I sort of missed the boat a little with it because I haven't done any Windows Administration since I used to look after Windows Server 2000 machines (and possibly a couple of 2003). At that time I had a different arsenal to cause untold woe on my fellow colleagues....VBSCRIPT!!!! Boy could I cause trouble with that. With a combination of that, VBA and SQL I used to love creating spider webs of pure madness, once written the apps were tied together so precariously; one false move and the entire thing would explode.... anyway that's a different story. Back to the Powershell. He was using it to automate IIS (or else I heard what I wanted to so I could try and push F# onto him, who knows?). I have heard various stories of extremely large platform automation scripts being written recently (for example  .net rocks interview with Steve Evans ) and whilst they seem to be g