Skip to main content

To Fix or Not To Fix...

Labels:

Comments

Dom Finn said…
<div>Agreed it's not always completely possible but you can often do something.?</div><div><br></div><div>Even if that something is just:?</div><div><br></div><div>Refactoring a specific function, tidy the code up, return early instead of late etc... as long as you are keeping to the return contract of the function you can't go far wrong.?</div> <div><br></div><div>Renaming, rename variables from foolishness like cuIDoW to CustomersIdOnWednesday (at least you can identify the foolery better then).?</div><div><br></div><div>Indeed, there is the risk of making it worse. Sometimes the spaghetti is so bad you can barely tell what the knock on effects of something are but you can still pick some small safe battles to fight and at least begin to identify what is rotten for the future.?</div> <div><br></div><div>You know the future of the project, the future is that it's coming back to get you. Like some foul curry beast from the night out of yesteryear. If it's not you it will be some other poor fool that is tasked with keeping it going 5 years after most of the team has moved onto other systems.?</div> <div><br></div><div>Is it the code you wrote yourself? Probably. Even if it's not, you can't generally blame the people involved, we are all on a journey. Although there's always the occasional Orc blasting out lol-code.</div> <div><br></div><div>As I say, it's just down to you what you do after you do know what you're doing. Do something, doooo it!?</div>
10 September 2012 at 14:29
Post a Comment

Popular posts from this blog

Creating star ratings in HTML and Javascript

I'd searched around a little for some shortcuts to help in doing this but I couldn't find anything satisfactory that included the ability to pull the rating off again for saving. I'd ended up coming up with this rather cheeky solution. Hopefully it helps you too! This is my first post in a while (I stopped blogging properly about 8 years ago!) It's strange coming back to it. Blogger feels very crusty and old by todays standards too.
Post a Comment
Read more

Make your objects immutable by default

More about the Good Dojo In my post last week , I discussed creating objects that are instantiated safely. Please go back and read if you are interested. At the end of the post, I mentioned that I'd also written the class so it was immutable when instantiated. This is important!!! I feel like a broken record in repeating this but I am sure at the time of writing your code, you aren't modifying your object all over the place and so are safe in the belief that protecting against mutability is overkill. Please remember though, your code could be around for a hell of a long time. You aren't writing your code for now... you are writing for the next fool that comes along (including you) . Nothing is more upsetting that coming back to fix a bug on some wonderfully crafted code to say "Who has butchered my code?!", but often you were involved at the start of the process. You made the code easy to modify, allowing objects to be used / reused / modified without thi
Post a Comment
Read more

An instantiated object should be "ok"

I've been QA'ing quite a bit of work recently and one common theme I've noticed across both Java and C# projects I have been looking at is that we occasionally open ourselves up unessacarily to Exceptions by the way objects are being created. My general rule of thumb (which I have seen mentioned in a Pluralsight video recently but also always re-iterate in various Robust Software talks I have done) is that you shouldn't be able to create an object and then call a method or access a property that then throws an exception. At worst, it should return null (I'm not going to moan about that now). I've created an example below. We have two Dojos, one is good and one is bad. The bad dojo looks very familiar though. It's a little class written in the style that seems often encouraged. In fact, many classes start life as something like this. Then as years go on, you and other colleagues add more features to the class and it's instantiation becomes a second
Post a Comment
Read more